[browser] Check also corePdb to see if we have any pdb to start debugging #117978
Conversation
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a debugging support detection issue in the browser runtime by checking both corePdb and pdb resources to determine if debugging symbols are available. The issue occurs when AOT compilation is enabled, which moves all PDB files to the corePdb collection, causing the original check to fail.
Key changes:
- Updates debugging support check to consider both
corePdbandpdbresources - Adds proper merging support for
coreAssemblyandcorePdbcollections in the configuration merge function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mono/browser/runtime/startup.ts | Updates debugging condition to check both corePdb and pdb resources |
| src/mono/browser/runtime/loader/config.ts | Adds merging logic for coreAssembly and corePdb collections |
|
We don't need any other change on BrowserDebugProxy? To read the pdb's correctly, since the PDB's will be in this corePdb? |
@thaystg We are passing loaded files from runtime to debugger in https://github.com/maraf/runtime/blob/maraf/BrowserAotDebug/src/mono/browser/runtime/assets.ts#L120, aren't we? If so, we are fine, since this array contains all of the loaded files, no matter where they came from. |
|
/ba-g Timeouts are not related |
|
/backport to release/10.0-preview7 |
|
Started backporting to release/10.0-preview7: https://github.com/dotnet/runtime/actions/runs/16500250253 |
4 participants
We should check both
resources.pdb&resources.corePdbto determine if we have pdbs loaded.Setting
RunAOTCompilation=trueresults in moving all pdbs tocorePdbwhich uncovers this bug.Unfortunately, the
DEBUGGING IS NOT ENABLEDmessage is coming from debugger when the other side is connected, so we don't have an easy way to read it in tests.Fixes dotnet/aspnetcore#62335